-
Notifications
You must be signed in to change notification settings - Fork 2.8k
add smooth scrolling to chat #5290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add smooth scrolling to chat #5290
Conversation
✅ Deploy Preview for continuedev canceled.
|
The main difference here is that currently we just jump to the last prompt, but this instead smooth scrolls? |
Also it appears this change is breaking one of the e2e tests: https://github.com/continuedev/continue/actions/runs/14595994283/job/40979633741?pr=5290#step:13:85 |
instead - I like when the newly submitted prompt "pops" to the top of the window and as the agent reply streams it will again scroll once the window is filled. |
Yes, we jump to the last prompt using smooth scroll.
checking this and fixing |
this will require some modifications to how we are rendering the history items as it was indicated here.
|
cc @RomneyDa here, I think you'll have an opinion. |
check first expect recheck try adding timeout place delay at correct position
53543a9
to
95b7239
Compare
This reverts commit 3588c95.
@uinstinct this can look nice especially if there's a long delay up to first token. I think it ends up looking worse if you're on a tall screen and the model responds quickly, because it's still scrolling while the model starts responding. To make it scroll fast enough we'd have to have the scroll finish in a couple hundred milliseconds which at that point looks jenky. Also, would need screenshots/more testing on truncating messages, one of the main reasons we abandoned autoscroll in the past was it often felt jenky when you go back and truncate the history at e.g. message 3/20 EDIT this was merged and then reverted #5408 |
Description
Recently I was used Gemini Code Assist and the chat smooth scrolling (and last prompt's sticky behaviour) on a new prompt was something I liked. I wanted to add this to Continue as well.
Whenever a new prompt is given, the chat scrolls to the bottom in smoothly.
(I wanted to also add the sticky behaviour of the prompt. It would require changes to how we render the history items such that all other items remain constant during generation)
Checklist
Screenshots
before.mp4
after.mp4
Testing instructions