Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chat mode cycling on VS Code #4987

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Apr 4, 2025

Description

The commit to disable cycling to edit mode on JB products used the wrong logic, thus preventing cycling to edit mode on VS Code. This PR simply inverts the check in sessionSlice.reducers.cycleMode.

Checklist

  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Testing instructions

Press Cmd+. or Ctrl+. to switch to Edit mode in the Chat webview on VS Code.

@fbricon fbricon requested a review from a team as a code owner April 4, 2025 11:59
@fbricon fbricon requested review from RomneyDa and removed request for a team April 4, 2025 11:59
Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 4b5533a
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67efc987983196000888e049

Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sestinj sestinj merged commit 90870bf into continuedev:main Apr 5, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants