Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified Listbox + Typescript version fix #4792

Merged
merged 15 commits into from
Mar 25, 2025
Merged

Unified Listbox + Typescript version fix #4792

merged 15 commits into from
Mar 25, 2025

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Mar 24, 2025 •
edited
Loading

Description

  • Unify listboxes into one listbox with mostly consistent styles
  • Upgrade to headless UI 2.2 to support anchor for auto opening in a logical direction
  • Update lump and assistant selector size interactions
  • Add local storage provider used for fontSize (for now)
  • Fix various issues with Edit mode state when using mode selection dropdown
  • Update typescript dependency to be explicitly the same across package.jsons

@netlify Netlify
Copy link

netlify bot commented Mar 24, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 48bdd91
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67e258ec4a688e00086f7b08

@RomneyDa RomneyDa marked this pull request as ready for review March 25, 2025 02:56
@RomneyDa RomneyDa requested a review from a team as a code owner March 25, 2025 02:56
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team March 25, 2025 02:56
@RomneyDa RomneyDa changed the title Unified Listbox Unified Listbox + Typescript type Mar 25, 2025
@RomneyDa RomneyDa changed the title Unified Listbox + Typescript type Unified Listbox + Typescript version Mar 25, 2025
@RomneyDa RomneyDa changed the title Unified Listbox + Typescript version Unified Listbox + Typescript version fix Mar 25, 2025
@sestinj sestinj merged commit dccb044 into main Mar 25, 2025
31 checks passed
@sestinj sestinj deleted the dallin/unified-listbox branch March 25, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrick-Erichsen Patrick-Erichsen Patrick-Erichsen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomneyDa @Patrick-Erichsen @sestinj