-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: conversation starters #4758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
32161b6
a73123e
1d1f705
d3f4aeb
730ac56
efff2d3
f968e32
9c2db6b
b82d29c
0819bec
d6ad3e2
2f199ff
61ea04b
71f8508
5c1d81e
4718c12
4c030c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤯🤯🤯🤯🤯 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is valid since all prompt files are now rendered as slash commands. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this was just excitement hahaha |
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. consider renaming/moving file/function to reflect v2 support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stylistically prefer old way, not important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted this to the @tomasz-stefaniak oracle (e.g. Clean Code assistant)
Prompt
which version is cleaner?
Response
The first version using destructuring is cleaner and more maintainable for several reasons:
Advantages of the first version:
...
) to explicitly show we're removing therun
property while keeping everything elseThe second version:
Has these drawbacks:
The first version is the better choice as it's more maintainable, flexible, and follows SOLID principles better. It also makes it very clear that we're intentionally excluding the
run
property while preserving everything else.I made the update mostly stylistically but I think I agree with the points made by the model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!