Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect use cases where systemMessage is missing #4724

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Protect use cases where systemMessage is missing #4724

merged 1 commit into from
Mar 19, 2025

Conversation

mdelder
Copy link
Contributor

@mdelder mdelder commented Mar 19, 2025

Description

Fixes issue #4723

  1. messageContent.ts#renderChatMessages is protected from use cases where there is no systemMessage.
  2. VertexAI.ts was updated to tolerate when none of the messages have a 'system' role.

Checklist

  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. ]

Testing instructions

See the reproduction instructions on #4723.

@mdelder mdelder requested a review from a team as a code owner March 19, 2025 13:40
@mdelder mdelder requested review from RomneyDa and removed request for a team March 19, 2025 13:40
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit f9c77c6
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67dac946e43b750008311ca7

sestinj
sestinj approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@sestinj sestinj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @mdelder !

@sestinj sestinj merged commit a18f3b4 into continuedev:main Mar 19, 2025
30 checks passed
@sestinj
Copy link
Contributor

sestinj commented Mar 19, 2025

This will make it to pre-release v1.1.13 in VS Code later today!

@mdelder
Copy link
Contributor Author

mdelder commented Mar 20, 2025

@sestinj Please also apply this fix: #4714

Together, I was able to successfully use Claude 3.7 on VertexAI with support for Chat and Edit. I'm working on getting Tools working correctly for this use case.

@Patrick-Erichsen Patrick-Erichsen mentioned this pull request Mar 21, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sestinj sestinj sestinj approved these changes

@RomneyDa RomneyDa Awaiting requested review from RomneyDa RomneyDa is a code owner automatically assigned from continuedev/continue-code-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdelder @sestinj