Skip to content

Remove tool use system instructions #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 7 additions & 35 deletions core/llm/constructMessages.ts
Original file line number Diff line number Diff line change
@@ -1,51 +1,23 @@
import {
ChatHistoryItem,
ChatMessage,
MessagePart,
ModelDescription,
} from "../";
import { ChatHistoryItem, ChatMessage, MessagePart } from "../";
import { normalizeToMessageParts } from "../util/messageContent";

import { modelSupportsTools } from "./autodetect";

const TOOL_USE_RULES = `<tool_use_rules>
When using tools, follow the following guidelines:
- Avoid calling tools unless they are absolutely necessary. For example, if you are asked a simple programming question you do not need web search. As another example, if the user asks you to explain something about code, do not create a new file.
</tool_use_rules>`;

function constructSystemPrompt(
modelDescription: ModelDescription,
useTools: boolean,
): string | null {
let systemMessage = `<important_rules>
const DEFAULT_SYSTEM_MESSAGE = `<important_rules>
Always include the language and file name in the info string when you write code blocks. If you are editing "src/main.py" for example, your code block should start with '\`\`\`python src/main.py'.
</important_rules>`;
if (useTools && modelSupportsTools(modelDescription)) {
systemMessage += "\n\n" + TOOL_USE_RULES;
}
return systemMessage;
}

const CANCELED_TOOL_CALL_MESSAGE =
"This tool call was cancelled by the user. You should clarify next steps, as they don't wish for you to use this tool.";

export function constructMessages(
history: ChatHistoryItem[],
modelDescription: ModelDescription,
useTools: boolean,
): ChatMessage[] {
export function constructMessages(history: ChatHistoryItem[]): ChatMessage[] {
const filteredHistory = history.filter(
(item) => item.message.role !== "system",
);
const msgs: ChatMessage[] = [];

const systemMessage = constructSystemPrompt(modelDescription, useTools);
if (systemMessage) {
msgs.push({
role: "system",
content: systemMessage,
});
}
msgs.push({
role: "system",
content: DEFAULT_SYSTEM_MESSAGE,
});

for (let i = 0; i < filteredHistory.length; i++) {
const historyItem = filteredHistory[i];
Expand Down
6 changes: 1 addition & 5 deletions gui/src/redux/thunks/streamResponse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,7 @@ export const streamResponseThunk = createAsyncThunk<

// Construct messages from updated history
const updatedHistory = getState().session.history;
const messages = constructMessages(
[...updatedHistory],
defaultModel,
useTools,
);
const messages = constructMessages([...updatedHistory]);

posthog.capture("step run", {
step_name: "User Input",
Expand Down
6 changes: 1 addition & 5 deletions gui/src/redux/thunks/streamResponseAfterToolCall.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@ export const streamResponseAfterToolCall = createAsyncThunk<
dispatch(setActive());

const updatedHistory = getState().session.history;
const messages = constructMessages(
[...updatedHistory],
defaultModel,
useTools,
);
const messages = constructMessages([...updatedHistory]);
const output = await dispatch(streamNormalInput(messages));
unwrapResult(output);
}),
Expand Down
Loading