fix: Eliminate Uncaught TypeError in dev tools #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@sestinj JS_QUERY_POOL_SIZE? It is just a configuration parameter in jbcef, and maybe it can be configured in the tools settings in JetBrains, but I don't think users will care about it. |
sestinj
requested changes
Mar 17, 2025
| @@ -43,11 +43,6 @@ class ContinuePluginToolWindowFactory : ToolWindowFactory, DumbAware { | |||
| class ContinuePluginWindow(project: Project) { | |||
| private val defaultGUIUrl = "http://continue/index.html" | |||
|
|
|||
| init { | |||
| System.setProperty("ide.browser.jcef.jsQueryPoolSize", JS_QUERY_POOL_SIZE) | |||
| System.setProperty("ide.browser.jcef.contextMenu.devTools.enabled", "true") | |||
There was a problem hiding this comment.
This is the line I'm referencing. It allows you to right click and "Open Dev Tools" which is very useful for debugging
|
@sestinj Oh, actually it has been an invalid configuration, it will only take effect when jcef is opened when starting the plugin, even if we don't configure it, we can still open it by right clicking and "Open Dev Tools". |
sestinj
approved these changes
Mar 17, 2025
jimmyek85
pushed a commit
to jimmyek85/continue
that referenced
this pull request
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminate the
Uncaught TypeError: window.cefQuery_xxx is not a functionerror that keeps appearing in the JS debug console.Screenshots