Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tools support for fireworks.ai #4560

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

2hy6v
Copy link
Contributor

@2hy6v 2hy6v commented Mar 9, 2025

(as requested reopened from #4046)

Description

Added support for tools for the models who support tooling running via fireworks.ai.
Its also using openai api with some quirks.
Left behind explanation in comment section.

https://docs.fireworks.ai/guides/function-calling

Testing instructions

If one wanted to do so:

  1. Check if tooling still works with other providers (I have no other providers available to me, but the changes are just a few lines and I don't think anything can go wrong here)
  2. Use fireworks.ai as provider with and check if tooling works (it does for me now)

Todo

Proper versioning, idk how you guys handle this nor if I should have done anything in that regard since its my first contribution. I could not find anything regarding that in the Contributing.md

Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit ba80343
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67cdb5263d580d0008d79e40

Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for re-opening!

@sestinj sestinj merged commit 66335c6 into continuedev:main Mar 9, 2025
30 checks passed
@pczekaj
Copy link
Contributor

pczekaj commented Apr 3, 2025

@2hy6v this change breaks o3-mini when continue dev operates in agent mode and tools are enabled, continue sends parallel_tool_calls and in response gets

400 Unsupported parameter: 'parallel_tool_calls' is not supported with this model.

in the past I fixed it with https://github.com/continuedev/continue/pull/4062/files but this PR reverted it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants