Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for setting IGNORE_SSH_TESTS #4556

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

owtaylor
Copy link
Contributor

@owtaylor owtaylor commented Mar 9, 2025

The logic for checking for dependabot introduced in
fda4cc8 skip ssh on dependabot PRs
was somewhat confused; this was partially fixed in
98739c6 fix ignore api key tests

This makes the logic for IGNORE_SSH_TESTS match that for IGNORE_API_KEY_TESTS and
be a proper logic opposite of:

if: ${{ github.event.pull_request.head.repo.fork == false && github.actor != 'dependabot[bot]' }} 

The logic for checking for dependabot introduced in
    fda4cc8 skip ssh on dependabot PRs
was somewhat confused; this was partially fixed in
    98739c6 fix ignore api key tests
Make IGNORE_SSH_TESTS match.
Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 7e0b3d9
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67cd6ea71fe5870008cb1a37

@sestinj sestinj merged commit 5b4d63e into continuedev:main Mar 9, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants