Skip to content

Index fixes #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2025
Merged

Index fixes #4322

merged 6 commits into from
Mar 4, 2025

Conversation

JubilantJerry
Copy link
Contributor

Description

Fixes for indexing and @codebase issues #4239, #4252, #4254, #4255

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 963713d
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67c6692e56001200088ba99f
😎 Deploy Preview https://deploy-preview-4322--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JubilantJerry JubilantJerry force-pushed the index-fixes branch 3 times, most recently from b7d29d0 to 9bfa737 Compare February 25, 2025 06:22
@JubilantJerry JubilantJerry force-pushed the index-fixes branch 2 times, most recently from 6c3756a to 7c7fa03 Compare February 25, 2025 07:25
@Patrick-Erichsen
Copy link
Collaborator

Hey @JubilantJerry , apologies for the slow review time here, it's been a busy past few weeks prepping our 1.0 launch.

This all looks solid but mind sharing a bit of an overview of what these changes entail? Also, if there's any tests you could write in core/indexing/LanceDbIndex.test.ts, core/indexing/FullTextSearchCodebaseIndex.test.ts, core/indexing/refreshIndex.test.ts, and core/indexing/CodebaseIndexer.test.ts to help us validate these changes that would also be much appreciated. All of the issues you linked to are pretty big problems so definitely want to get these changes in but would like to make sure we have tests so we don't have regressions in the future.

@Patrick-Erichsen
Copy link
Collaborator

@JubilantJerry I went through some of the issues you linked actually and that provides plenty of context for the changes here.

I pushed up a quick merge conflict resolution just now, and once the tests pass here I'm going to merge to main. However, if there's any test you think would be valuable to add to help us prevent future regressions that would be a great followup.

Thanks again for all the huge improvements here, and for documenting the issues in the first place!

@Patrick-Erichsen Patrick-Erichsen merged commit 0a63756 into continuedev:main Mar 4, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants