Skip to content

feat: use @lancedb/vectordb-win32-arm64-msvc #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/jetbrains-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ name: JetBrains Release

on:
release:
types: [ prereleased ]
types: [prereleased]
workflow_dispatch:
inputs:
publish_build:
description: 'Whether or not to publish the built extension to the JetBrains marketplace'
description: "Whether or not to publish the built extension to the JetBrains marketplace"
required: true
default: false

Expand Down Expand Up @@ -241,6 +241,12 @@ jobs:
name: continue-binary-win32-x64
path: ./binary/bin/win32-x64/

- name: Upload artifact (win32-arm64)
uses: actions/upload-artifact@v4
with:
name: continue-binary-win32-arm64
path: ./binary/bin/win32-arm64/

- name: Upload artifact (linux-arm64)
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -345,7 +351,7 @@ jobs:
# Run tests and upload a code coverage report
test:
name: Test
needs: [ build ]
needs: [build]
runs-on: ubuntu-latest
steps:
# Check out current repository
Expand Down Expand Up @@ -387,7 +393,7 @@ jobs:
inspectCode:
if: false
name: Inspect code
needs: [ build ]
needs: [build]
runs-on: ubuntu-latest
permissions:
contents: write
Expand Down Expand Up @@ -422,7 +428,7 @@ jobs:
verify:
if: false
name: Verify plugin
needs: [ build ]
needs: [build]
runs-on: ubuntu-latest
steps:
# Free GitHub Actions Environment Disk Space
Expand Down
3 changes: 2 additions & 1 deletion binary/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ let targets = [
"linux-x64",
"linux-arm64",
"win32-x64",
"win32-arm64",
];

const [currentPlatform, currentArch] = autodetectPlatformAndArch();
Expand All @@ -53,7 +54,7 @@ const targetToLanceDb = {
"linux-arm64": "@lancedb/vectordb-linux-arm64-gnu",
"linux-x64": "@lancedb/vectordb-linux-x64-gnu",
"win32-x64": "@lancedb/vectordb-win32-x64-msvc",
"win32-arm64": "@lancedb/vectordb-win32-x64-msvc", // they don't have a win32-arm64 build
"win32-arm64": "@lancedb/vectordb-win32-arm64-msvc",
};

async function installNodeModuleInTempDirAndCopyToCurrent(packageName, toCopy) {
Expand Down
6 changes: 3 additions & 3 deletions extensions/vscode/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion extensions/vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,6 @@
"quick-test": "npm run build-test && node ./out/runTestOnVSCodeHost.js",
"prepackage": "node scripts/prepackage.js",
"package": "node scripts/package.js",
"package-all": "node scripts/package-all.js",
"package:pre-release": "node scripts/package.js --pre-release",
"build:rust": "cargo-cp-artifact -ac sync sync.node -- cargo build --manifest-path ../../sync/Cargo.toml --message-format=json-render-diagnostics",
"build-debug:rust": "npm run build:rust --",
Expand Down
33 changes: 0 additions & 33 deletions extensions/vscode/scripts/package-all.js

This file was deleted.

218 changes: 0 additions & 218 deletions extensions/vscode/scripts/prepackage-cross-platform.js

This file was deleted.

Loading
Loading