Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Autocomplete not working when lookup is selected #3924

Merged
merged 6 commits into from
Mar 16, 2025

Conversation

lkk214
Copy link
Contributor

@lkk214 lkk214 commented Feb 1, 2025

No description provided.

Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit a8074b1
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67d56a7414cc660008ac0d4c
😎 Deploy Preview https://deploy-preview-3924--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sestinj
Copy link
Contributor

sestinj commented Mar 8, 2025

@lkk214 thanks for the fix here! Apologies for being slow to review. Do you have a better example of the problem this is solving? A screenshot or something might help

@lkk214
Copy link
Contributor Author

lkk214 commented Mar 8, 2025

lookup

If the def in lookup is accepted, isLookupShown is always false because LookupListener.itemSelected is not processed, causing the autocomplete to be skipped.

code related to skip rendering completion:

private fun shouldSkipRender(settings: ContinueExtensionSettings) =
!settings.continueState.showIDECompletionSideBySide && !autocompleteLookupListener.isLookupEmpty()

@sestinj sestinj merged commit 7bb5257 into continuedev:main Mar 16, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants