full screen now opens in front of vscode #3741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
sestinj
approved these changes
Jan 18, 2025
|
Could we stop calling it full screen and rename that feature "Detach window" or anything more accurate than "full screen"? |
|
@fbricon I'm not opposed but I did not name the feature, I would just make a PR or convince one of the maintainers. |
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
had a problem deploying
to
tests-requiring-secrets
GitHub Actions
Failure
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
sestinj
temporarily deployed
to
tests-requiring-secrets
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
full screen opens behind vscode making it so the initial perceived effect of the toggle fullscreen is just closing the sidebar, this fixes that, it will now open in front.
Checklist
Screenshots
[ For visual changes, include screenshots. ]
Testing instructions