Skip to content

build: Integrates prebuilt library release workflow #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 23, 2025

Conversation

gpeacock
Copy link
Collaborator

Changes in this pull request

Give a narrative description of what has been changed.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

gpeacock added 28 commits May 16, 2025 16:26
moves some Reader functionality to Store
store tests under v1_api until we resolve issues.
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 76.06838% with 28 lines in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (b543622) to head (411a3a1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/reader.rs 60.00% 10 Missing ⚠️
c_api/src/json_api.rs 0.00% 9 Missing ⚠️
c_api/src/c_api.rs 0.00% 8 Missing ⚠️
sdk/src/store.rs 98.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   80.82%   80.66%   -0.17%     
==========================================
  Files         143      143              
  Lines       38355    38382      +27     
==========================================
- Hits        31001    30959      -42     
- Misses       7354     7423      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpeacock gpeacock changed the title build(c_api): Integrates prebuilt library release workflow build: Integrates prebuilt library release workflow May 22, 2025
@cdmurph32
Copy link
Collaborator

Runningcargo build -p c_api the c_api will build without openssl.
Running cargo build the c_api will build with openssl.
It doesn't go back and build c2pa again without openssl.

cdmurph32 and others added 4 commits May 22, 2025 20:23
Now that `json_api` has been removed the WASI test isn't as different.
All features are now named in c2pa crate.
@gpeacock gpeacock merged commit a706658 into main May 23, 2025
33 of 36 checks passed
@gpeacock gpeacock deleted the gpeacock/workspace_versions branch May 23, 2025 01:53
This was referenced May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants