Skip to content

feat: Make OpenSSL a default feature #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 20, 2025
Merged

feat: Make OpenSSL a default feature #1118

merged 7 commits into from
May 20, 2025

Conversation

cdmurph32
Copy link
Collaborator

@cdmurph32 cdmurph32 commented May 19, 2025

Changes in this pull request

Openssl will not be included when building rust native crypto
CI tests for both openssl and rust_native_crypto features

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.82%. Comparing base (bfb69aa) to head (d9b3ed4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
+ Coverage   80.30%   80.82%   +0.51%     
==========================================
  Files         153      143      -10     
  Lines       39323    38355     -968     
==========================================
- Hits        31579    31001     -578     
+ Misses       7744     7354     -390     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdmurph32 cdmurph32 force-pushed the openssl_feature2 branch 4 times, most recently from 8906876 to 56ee127 Compare May 20, 2025 00:55
@cdmurph32 cdmurph32 marked this pull request as ready for review May 20, 2025 01:28
@scouten-adobe scouten-adobe changed the title feat: Make openssl a default feature. feat: Make OpenSSL a default feature May 20, 2025
Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly 👍 but I have a concern about how values are passed between the GitHub Action steps.

Openssl will not be included when building rust native crypto
Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things; otherwise 👍.

@cdmurph32 cdmurph32 merged commit f00f6a0 into main May 20, 2025
31 checks passed
@cdmurph32 cdmurph32 deleted the openssl_feature2 branch May 20, 2025 20:00
@caiopensrc caiopensrc mentioned this pull request May 20, 2025
n8fr8 pushed a commit to n8fr8/c2pa-rs that referenced this pull request May 22, 2025
Openssl will not be included when building rust native crypto

---------

Co-authored-by: Eric Scouten <[email protected]>
@caiopensrc caiopensrc mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants