-
Notifications
You must be signed in to change notification settings - Fork 82
feat: Make OpenSSL a default feature #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
+ Coverage 80.30% 80.82% +0.51%
==========================================
Files 153 143 -10
Lines 39323 38355 -968
==========================================
- Hits 31579 31001 -578
+ Misses 7744 7354 -390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
45d9730
to
ab56be6
Compare
8906876
to
56ee127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly 👍 but I have a concern about how values are passed between the GitHub Action steps.
Openssl will not be included when building rust native crypto
8031e0b
to
201d970
Compare
201d970
to
d32184f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor things; otherwise 👍.
Openssl will not be included when building rust native crypto --------- Co-authored-by: Eric Scouten <[email protected]>
Changes in this pull request
Openssl will not be included when building rust native crypto
CI tests for both openssl and rust_native_crypto features
Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.