Use Mtimespec instead of Mtim to compile on darwin #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nalind PTAL |
|
LGTM, merging. |
|
@nalind you should not trust me :-) i forgot to try to run this on linux and it breaks for some reason... Can you please revert this? |
|
This seems to be why PRs in c/image are failing containers/image#195 |
|
@runcom for some reason this works on OSX but not on Linux :-/ I wonder if there a way to make this work on both, but for now I think we should revert this commit |
|
Can I get you to look over #11 and see if it works for you? |
|
Okay, reverted this one and readded it as the first patch in #11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the
syscalltogolang.org/x/sys/unix(see: https://golang.org/pkg/syscall).Also use
Mtimespecinstead ofMtimso this library compile on darwin.