libpod: add pullprogress to /libpod/images/pull
#26444
Draft
+204
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
github-actions
bot
added
kind/api-change
|
Please don't review this yet, I am still working on this PR. |
flouthoc
force-pushed
the
libpod_pull_progress
branch
from
3215338 to
b39cb3a
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
flouthoc
force-pushed
the
libpod_pull_progress
branch
from
b39cb3a to
d336353
Compare
Following PR attempts to expose `pull progress` of images while a user attempts to pull image using `libpod`'s API endpoint `/images/pull` using a newly introduced flag called `pullprogress`. Output is similar to `compatMode` but not exactly same. Idea is to maintain a new endpoint which does not have to adhere with `docker` compatibility and can be extended for new features easily. Following flag will expose some new fields to pullprogress and will be slowly extended with more features. Signed-off-by: flouthoc <[email protected]>
flouthoc
force-pushed
the
libpod_pull_progress
branch
from
d336353 to
af05715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR attempts to expose
pull progressof images while a user attempts to pull image usinglibpod's API endpoint/images/pullusing a newly introduced flag calledpullprogress.Output is similar to
compatModebut not exactly same. Idea is to maintain a new endpoint which does not have to adhere withdockercompatibility and can be extended for new features easily.Following flag will expose some new fields to pullprogress and will be slowly extended with more features.
Does this PR introduce a user-facing change?