-
Notifications
You must be signed in to change notification settings - Fork 106
Set X-Registry-Auth header on manifest push and bump to new API #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1eeb166
to
e53a67a
Compare
/assign umohnani8 |
@dklimpel Please add a test. TIA /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dklimpel, jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: dklimpel <[email protected]>
Signed-off-by: dklimpel <[email protected]>
Signed-off-by: dklimpel <[email protected]>
bb2cf26
to
16257d5
Compare
Signed-off-by: dklimpel <[email protected]>
I have added some tests. The failing test of CI The tests detected a wrong return type of |
/packit retest-failed |
1 similar comment
/packit retest-failed |
test flakes addressed, LGTM |
http://podman.io/libpod/manifests/{name}/push
)http://podman.io/libpod/manifests/{name}/registry/{destination}
I was already unable to use the old API with Podman 4.9
The current implementation for image push:
podman-py/podman/domain/images_manager.py
Lines 241 to 268 in a75e8c2