-
Notifications
You must be signed in to change notification settings - Fork 62
feat: added ability to select runtime for playground #3171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bc087d7
to
bdabfb0
Compare
A few questions:
|
@feloy good questions! That would be a good idea to remove openvino from mac for now 'ALL' in this case is a placeholder for every runtime provider besides a hardcoded exclusion. Essentially I wanted a way to list all the runtime providers in the playground creation and this made the most sense to me at the moment. There's most definitely a cleaner approach! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runtime select should be seen as a filter, no hardcoded all
, it should be clearable, if no value is selected, then all models should be listed.
No need to define what mean "all"
Thanks, @axel7083. That's a good way to handle it! In that case, should the runtime selection dropdown be defaulted to having no value so the user can see all the models available? |
@gastoner good catch I assumed "none" in this case was simply to have no selection. I did have a playground with resnet setup but since the model is used for object detection, I didn't get the chat to work. Maybe we can keep it excluded? |
Signed-off-by: Brian <[email protected]>
bdabfb0
to
385f589
Compare
Signed-off-by: Brian <[email protected]>
Signed-off-by: Brian <[email protected]>
Yes! By default no filtering |
@axel7083 updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested it and got 2 issues:
- in the selector the none value is presented but this value is useless because there are no inference servers for those kind of models: they are just there so that recipes can load them independently from an inference server
- when the inference runtime from the settings is different from all then it should be the default value of the selector here
59dad1b
to
c590339
Compare
@feloy I believe that Mac support for OpenVINO might be coming soon, maybe we can keep it as a selection? Also I was trying to import @podman-desktop/api to the frontend script playground create to use the env.ismac but it seems frontend scripts only have the ability to pull from pd ui-svelte. Is there an easier approach to having ismac usable for frontend? |
c590339
to
802118c
Compare
Signed-off-by: Brian <[email protected]>
802118c
to
c0281d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on Windows, works as expected 👍
What does this PR do?
adds the ability to select the runtime for playground
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #2613
How to test this PR?