Fix the library install name and path #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install_name is supposed to be an absolute path, and use the soname rather than the developer symlink. Avoids using DYLD_FALLBACK_LIBRARY_PATH=/usr/local/lib Homebrew changes the install_name downstream, in /opt. Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
requested review from
jakecorrenti,
MatiasVara,
mtjhrc,
slp and
tylerfanelli
as code owners
nirs
reviewed
Jun 10, 2025
slp
requested changes
Jun 12, 2025
There was a problem hiding this comment.
Thanks for the PR! I think that we should fix this the same way we did in Linux, by using rustc-cdylib-link-arg to pass -install_name, -current_version, and -compatibility_version.
|
Added the linker flags. We still need to rename and relocate the library, though. |
slp
reviewed
Jun 16, 2025
| @@ -5,5 +5,10 @@ fn main() { | |||
| std::env::var("CARGO_PKG_VERSION_MAJOR").unwrap() | |||
| ); | |||
| #[cfg(target_os = "macos")] | |||
| println!( | |||
| "cargo:rustc-cdylib-link-arg=-Wl,-install_name,libkrun.{}.dylib,-compatibility_version,1.0.0,-current_version,{}.0.0", | |||
| std::env::var("CARGO_PKG_VERSION_MAJOR").unwrap(), std::env::var("CARGO_PKG_VERSION_MINOR").unwrap() | |||
There was a problem hiding this comment.
Reading ld's manual, I'd say compatibility_version should be MAJOR.0.0, and current_version MAJOR.MINOR.RELEASE.
Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
install_name
branch
from
b0f7fd4 to
b317bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install_name is supposed to be an absolute path, and use the soname rather than the developer symlink.
Avoids using
DYLD_FALLBACK_LIBRARY_PATH=/usr/local/lib. Homebrew changes the install_name downstream, in /opt.The default is the absolute path of the build directory (not wanted)
Typical error:
dyld[36629]: Library not loaded: libkrun-efi.dylib