Tweak the Makefile to decouple EFI and GPU features #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoodman
requested review from
jakecorrenti,
MatiasVara,
mtjhrc,
slp and
tylerfanelli
as code owners
|
Thanks for the contribution @ggoodman, can you add a |
This tweaks the `EFI=1` make option so that it doesn't automatically bring along the `gpu` feature. Since `EFI` resets `FEATURE_FLAGS`, the test for `GPU` and `SND` (not implied by `efi` rust feature) are evaluated after. Signed-off-by: Geoffrey Goodman <[email protected]>
ggoodman
force-pushed
the
make-decouple-efi-gpu
branch
from
f2ce153 to
a514586
Compare
jakecorrenti
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Confirmed everything works with Podman still.
This will require a change in the various homebrew formulas to make sure we don't break users expecting the GPU functionality. cc/ @slp
Yup, but it's fine, I'll keep an eye on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the
EFI=1make option so that it doesn't automatically bring along thegpufeature. SinceEFIresetsFEATURE_FLAGS, the test forGPUandSND(not implied byefirust feature) are evaluated after.