Skip to content

Require crossbeam-channel 0.5.15 or higher #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/devices/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ virgl_resource_map2 = []

[dependencies]
bitflags = "1.2.0"
crossbeam-channel = "0.5"
crossbeam-channel = ">=0.5.15"
env_logger = "0.9.0"
libc = ">=0.2.39"
libloading = "0.8"
Expand Down
7 changes: 3 additions & 4 deletions src/devices/src/legacy/hvfgicv3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,9 @@ impl IrqChipT for HvfGicV3 {
if let Some(irq_line) = irq_line {
let ret = unsafe { (self.bindings.hv_gic_set_spi)(irq_line, true) };
if ret != HV_SUCCESS {
Err(DeviceError::FailedSignalingUsedQueue(io::Error::new(
io::ErrorKind::Other,
"HVF returned error when setting SPI",
)))
Err(DeviceError::FailedSignalingUsedQueue(
std::io::Error::other("HVF returned error when setting SPI"),
))
} else {
Ok(())
}
Expand Down
3 changes: 1 addition & 2 deletions src/devices/src/virtio/snd/mod.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use std::{
io::Error as IoError,
io::ErrorKind,
sync::{atomic::AtomicUsize, Arc, Mutex},
};

Expand Down Expand Up @@ -144,7 +143,7 @@ pub enum Error {

impl From<Error> for IoError {
fn from(e: Error) -> Self {
Self::new(ErrorKind::Other, e)
Self::other(e)
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/hvf/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ authors = ["Sergio Lopez <[email protected]>"]
edition = "2021"

[dependencies]
crossbeam-channel = "0.5"
crossbeam-channel = ">=0.5.15"
libloading = "0.8"
log = "0.4.0"
env_logger = "0.9.0"

arch = { path = "../arch" }
arch = { path = "../arch" }
2 changes: 1 addition & 1 deletion src/libkrun/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ snd = []
virgl_resource_map2 = []

[dependencies]
crossbeam-channel = "0.5"
crossbeam-channel = ">=0.5.15"
env_logger = "0.9.0"
libc = ">=0.2.39"
libloading = "0.8"
Expand Down
2 changes: 1 addition & 1 deletion src/utils/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env_logger = "0.9.0"
libc = ">=0.2.85"
log = "0.4.0"
vmm-sys-util = "0.12.1"
crossbeam-channel = "0.5"
crossbeam-channel = ">=0.5.15"

[target.'cfg(target_os = "linux")'.dependencies]
kvm-bindings = { version = ">=0.10", features = ["fam-wrappers"] }
2 changes: 1 addition & 1 deletion src/vmm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ gpu = []
snd = []

[dependencies]
crossbeam-channel = "0.5"
crossbeam-channel = ">=0.5.15"
env_logger = "0.9.0"
flate2 = "1.0.35"
libc = ">=0.2.39"
Expand Down
2 changes: 1 addition & 1 deletion src/vmm/src/macos/vstate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ impl Vcpu {
// _before_ running this, then there is nothing we can do.
Self::TLS_VCPU_PTR.with(|cell: &VcpuCell| {
if let Some(vcpu_ptr) = cell.get() {
if vcpu_ptr == self as *const Vcpu {
if std::ptr::eq(vcpu_ptr, self) {
Self::TLS_VCPU_PTR.with(|cell: &VcpuCell| cell.take());
return Ok(());
}
Expand Down
Loading