Introduce a new krun_init_log() API #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecorrenti
reviewed
May 2, 2025
mtjhrc
force-pushed
the
log-api
branch
3 times, most recently
from
8c3c952 to
d19939c
Compare
Introduce a new krun_init_log public API function to allow for much more detailed configuration of logging by the application. The main improvment is is the ability to specify a file descriptor to write the log to. Signed-off-by: Matej Hrica <[email protected]>
chroot_vm is meant as an example and program to showcase libkrun APIs, we should at least show error messages by default even without RUST_LOG env variable. Signed-off-by: Matej Hrica <[email protected]>
Use the newer krun_init_log to support redirecting the log to a pipe. Signed-off-by: Matej Hrica <[email protected]>
The correct way to use the env_logger crate is to only depend on it the toplevel aplication crate. In other crates we should just use the `log` crate facade (which we already do). Drop the env_logger dependency from all of our internal crates, and just keep it in the the `libkrun` crate. Signed-off-by: Matej Hrica <[email protected]>
Use newest version of env_logger. This is needed to fix a problem where output to a pipe ignores RUST_LOG_STYLE=always option and colors don't work. Signed-off-by: Matej Hrica <[email protected]>
jakecorrenti
reviewed
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new krun_init_log public API function to allow for much detailed configuration of logging by the application. The main improvment is the ability to specify a file descriptor to write the log to.
This can be tested using the added
chroot_vmflags:--log=/path/to/a/pipeor--color-log=/path/to/a/pipe(which will also display a formatting).