Skip to content

include: Add #ifndef header guards #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

include: Add #ifndef header guards #311

merged 1 commit into from
Apr 11, 2025

Conversation

tylerfanelli
Copy link
Member

No description provided.

@tylerfanelli tylerfanelli force-pushed the include-header-guards branch from bc990f7 to 17353c7 Compare April 9, 2025 05:30
@nohajc
Copy link
Contributor

nohajc commented Apr 9, 2025

This reminds me you could also add

#ifdef __cplusplus
extern "C" {
#endif
...

mtjhrc
mtjhrc previously approved these changes Apr 9, 2025
View reviewed changes
mtjhrc
mtjhrc reviewed Apr 9, 2025
View reviewed changes
slp
slp requested changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@slp slp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, but please address @nohajc and @mtjhrc comments before merging.

@tylerfanelli tylerfanelli force-pushed the include-header-guards branch 2 times, most recently from 1a5d437 to 3c99739 Compare April 9, 2025 16:58
@tylerfanelli
Copy link
Member Author

@mtjhrc @nohajc Thanks for the suggestions, I've applied them. @slp Can you re-review?

@tylerfanelli tylerfanelli force-pushed the include-header-guards branch from 3c99739 to 69cf00e Compare April 9, 2025 16:59
@tylerfanelli tylerfanelli force-pushed the include-header-guards branch from 69cf00e to dd8d27e Compare April 10, 2025 19:43
slp
slp approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@slp slp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@slp slp merged commit 0237f1b into containers:main Apr 11, 2025
6 checks passed
@tylerfanelli tylerfanelli deleted the include-header-guards branch April 22, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtjhrc mtjhrc mtjhrc left review comments

@slp slp slp approved these changes

@jakecorrenti jakecorrenti Awaiting requested review from jakecorrenti jakecorrenti is a code owner

@MatiasVara MatiasVara Awaiting requested review from MatiasVara MatiasVara is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylerfanelli @nohajc @slp @mtjhrc