vmm/linux/vstate: support KVM SystemEvents #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On aarch64, we receive the shutdown/reset signals as KVM SystemEvents. Let's identify them properly to avoid printing an error on exit. Signed-off-by: Sergio Lopez <[email protected]>
slp
requested review from
jakecorrenti,
MatiasVara,
mtjhrc and
tylerfanelli
as code owners
tylerfanelli
approved these changes
Apr 4, 2025
tylerfanelli
approved these changes
Apr 4, 2025
| @@ -1129,6 +1131,14 @@ impl Vcpu { | |||
| error!("Received KVM_EXIT_INTERNAL_ERROR signal"); | |||
| Err(Error::VcpuUnhandledKvmExit) | |||
| } | |||
| VcpuExit::SystemEvent(event, _reason) => { | |||
There was a problem hiding this comment.
Should this be tagged behind #[cfg(target_arch = "aarch64")]? If not gaining anything from adding it, I'd say no, but just making sure.
There was a problem hiding this comment.
On x86_64 we don't hit that one right now, because we shut down with a triple fault, but it's valid a could eventually happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On aarch64, we receive the shutdown/reset signals as KVM SystemEvents. Let's identify them properly to avoid printing an error on exit.