devices: set CacheType::Unsafe for macOS raw disks #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohajc
requested review from
jakecorrenti,
MatiasVara,
mtjhrc,
slp and
tylerfanelli
as code owners
nohajc
force-pushed
the
disable-cache-for-raw-disks
branch
2 times, most recently
from
5738c9d to
1ad4667
Compare
tylerfanelli
previously approved these changes
Apr 3, 2025
|
@slp said
Besides, there's no practical reason to use |
slp
reviewed
Apr 3, 2025
nohajc
force-pushed
the
disable-cache-for-raw-disks
branch
from
1ad4667 to
a456e6a
Compare
|
Don't know what's with the failing checks now... they seem unrelated. |
nohajc
force-pushed
the
disable-cache-for-raw-disks
branch
from
a456e6a to
9f3a706
Compare
Ugg... we've got hit again by another clippy update with new restrictions. I'll fix it in a different PR, and the we can rebase this one. |
|
I also noticed a crash in unit tests... |
Yes, and I can reproduce the failure here after updating to |
Signed-off-by: Jan Noha <[email protected]>
nohajc
force-pushed
the
disable-cache-for-raw-disks
branch
from
9f3a706 to
4a45522
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #293