Revert "vsock: Fix TCP connection bug" and implement a different approach #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slp
requested review from
jakecorrenti,
MatiasVara,
mtjhrc and
tylerfanelli
as code owners
…y state" This reverts commit 3bd3b98. Signed-off-by: Sergio Lopez <[email protected]>
slp
force-pushed
the
revert-vsock-unconfirmed
branch
from
cef45c9 to
b2434ea
Compare
As indicated in 3bd3b98, when a client in the guest attempts to send data to the server immediately after connecting to it, we might receive data in the TCP socket before we're able to actually process it. To avoid this situation, delay setting EventSet::IN until the vsock transport has been established in confirm_connect. Signed-off-by: Sergio Lopez <[email protected]>
On slow hosts (i.e. running with nested virt), when the server is inside the guest, the client may fail to connect because the first is not yet ready. Make the test attempt to connect multiple times, waiting a second between attempts. Signed-off-by: Sergio Lopez <[email protected]>
slp
force-pushed
the
revert-vsock-unconfirmed
branch
from
b2434ea to
f8cef18
Compare
Closed
|
I can confirm it fixes my issue. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #294 while implementing another approach for fixing the problem addressed by 3bd3b98