upgrade imago to 0.1.4 #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Noha <[email protected]>
nohajc
requested review from
jakecorrenti,
MatiasVara,
mtjhrc,
slp and
tylerfanelli
as code owners
jakecorrenti
approved these changes
Mar 19, 2025
|
Why do we need to wait for a Fedora release of imago? |
I suppose I assumed that would be the case since we needed to vendor the crate before it was in Fedora. I should have phrased my original comment as a question of whether we needed to wait. If that's not the case then everything looks good to me. |
|
We'll need it when we release for Fedora, but that's a downstream process requirement. We don't have to let upstream wait because of it. |
Sounds good. Thanks for the clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275