fix(nvidia-bootc): Use INSTRUCTLAB_IMAGE_PULL_SECRET in podman pull command #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastequo
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
Gregory-Pereira
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
This change looks fine to me. We may also want to include that variable in the id for the secret mount (https://github.com/containers/ai-lab-recipes/pull/701/files#diff-9ead9b5738689076acfa144d52827f6aa3e74d9b9cf5187ddea991a3cc81e6c2R207) but ill leave that at your discression.
…ommand Signed-off-by: Matthieu Bernardin <[email protected]>
pastequo
force-pushed
the
nvidia-bootc/fix/pull-secret-command
branch
from
4f8c163 to
c05f23a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #699