-
Notifications
You must be signed in to change notification settings - Fork 49
Add option to whitelist domain from containment #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! I will test your patch as soon as possible. Also it needs a quick rebase @hackerncoder what do you think? |
I rebased it now. I've noticed that pressing enter in the extension preferences triggers saving the preferences. |
Before we used a simple text input, which wasn't able to contain multiple lines
The whitelist option uses a textarea element now, so it is possible to enter multiple domains. |
This is some serious code, and somewhat out of my ballpark (especially since I don't have that much energy right now), but seems fine. |
I tried it a little (google.com and blogger.com) and it seems fine. |
@sents after hackerncoder's test I merged and released this feature. the containment is broken if the whitelisted google urls are empty -> by default the containment is broken |
I can't reproduce this. |
I'll look into it today. |
Unfortunately I am not able to reproduce the bugs relating to the empty whitelist. I've tried my standard profile and a fresh profile without any other extensions. |
In case you downloaded from AMO - I disabled version 1.5.2 there. If you download https://github.com/containers-everywhere/contain-google/releases/download/1.5.2/google_container-1.5.2.zip, create a fresh profile, use debug addons -> load temporary addon you should be able to reproduce it. |
I installed it on a different computer with Firefox 82 and could reproduce the bug. For some reason whitespace gets inserted into the setting when loading the settings for the first time. Thank you for your tip! I will now look into this. |
After the fix of #109 leaving the whitelist empty doesn't cause any problems anymore. |
This pull request adds an option to include a list of whitelisted domains.
It is my first real pull request so I hope I am doing this right.
Note that this would fix #104.