host-local: still allocate empty file to avoid IP leak #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may happen when host-local creates an empty file successfully, but fails to write string into it and further fails to remove it. Many empty file will be created if runtime retries to create a new container until all free IPs are leaked in the range set. The root cause is that host-local cannot handle this kind of error when performing a rollback. We should check if IP file is empty, this prevents exhausting all free IPs and helps to recover leaked IP files. Fix containernetworking#498 Signed-off-by: chenyaqi01 <[email protected]>
chendotjs
force-pushed
the
host-local-leak
branch
from
9391a66 to
2cb14bd
Compare
|
While you're at this, can you fix the root bug, and create the reserved file atomically? It would involve writing to a temporary file, then renaming that file to the final filename. |
|
It looks like we'll have to implement our own rename that calls |
|
This PR has been untouched for too long without an update. It will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #498