supplement ns building files for darwin OS #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
requested changes
May 13, 2024
Signed-off-by: Icarus Wu <[email protected]>
Icarus9913
force-pushed
the
chore/darwin-ns
branch
from
a10377d to
1e7858f
Compare
Done |
squeed
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since The PR #890 add ns validation, it introduced the OS building incompatibility into
skelusage.And you can also see that under https://github.com/containernetworking/cni/tree/main/pkg/ns folder, we only have
linuxandwindowswhich make it inconvenient to do some Unit Test for thedarwinOS.So, this PR supplement ns building files for darwin OS. Then you can also test the
skelbuildings in thedarwinOS