Update routes option within adapter builders to allow multiple service functions
#1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3rpp
force-pushed
the
main
branch
2 times, most recently
from
5f5de95 to
ccfc3ba
Compare
Signed-off-by: d3rpp <[email protected]>
added to other adapters Signed-off-by: d3rpp <[email protected]>
Signed-off-by: d3rpp <[email protected]>
Signed-off-by: d3rpp <[email protected]>
Signed-off-by: d3rpp <[email protected]>
Signed-off-by: d3rpp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly simple PR that adds the ability to include more than one function in the
routesoption of the various adapters.I've been able to test it successfully on a small Bun project (internally at my company unfortunately).
This change is backwards compatible as you're still able to pass a single function.
If this feature requires its own conformance tests, I'd be happy to look into it, though none of the adapter/middleware/etc. files seem to have tests as is.