Skip to content

Add recipe for google-cloud-aiplatform #18014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Add recipe for google-cloud-aiplatform #18014

wants to merge 8 commits into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 11, 2022 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/google-cloud-aiplatform) and found some lint.

Here's what I've got...

For recipes/google-cloud-aiplatform:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@parthea parthea force-pushed the add-recipe-google-cloud-aiplatform branch 2 times, most recently from 84d5274 to d19ebaa Compare February 11, 2022 18:30
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/google-cloud-aiplatform) and found it was in an excellent condition.

@parthea parthea force-pushed the add-recipe-google-cloud-aiplatform branch from d19ebaa to 2770104 Compare February 11, 2022 18:33
parthea
parthea commented Feb 11, 2022
View reviewed changes
recipes/google-cloud-aiplatform/meta.yaml
extra:
recipe-maintainers:
- parthea
- morgandu
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgandu Please confirm that you'd like to be added as a maintainer (as per checklist)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please add me as maintainer.

tswast
tswast reviewed Feb 11, 2022
View reviewed changes
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/google-cloud-aiplatform) and found some lint.

Here's what I've got...

For recipes/google-cloud-aiplatform:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

tswast
tswast reviewed Feb 11, 2022
View reviewed changes
parthea and others added 2 commits February 11, 2022 14:33
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/google-cloud-aiplatform) and found some lint.

Here's what I've got...

For recipes/google-cloud-aiplatform:

  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/google-cloud-aiplatform) and found it was in an excellent condition.

@parthea parthea marked this pull request as ready for review February 12, 2022 00:07
@parthea
Copy link
Contributor Author

parthea commented Feb 12, 2022

@conda-forge/help-python, please could you review/approve?

BastianZim
BastianZim reviewed Feb 12, 2022
View reviewed changes
recipes/google-cloud-aiplatform/meta.yaml Outdated
Comment on lines 3 to 5
{% set sha256 = "89d2936985eaf71a52152fe62bae9d7554dec6948032526b99ec05a049d1ee39" %}
{% set dev_url = "https://github.com/googleapis/python-aiplatform" %}
{% set doc_url = "https://cloud.google.com/python/docs/reference/aiplatform/latest" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's just used once or twice it's better to have this hardcoded. Makes it easier for the bot as well. Please add these three directly instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

recipes/google-cloud-aiplatform/meta.yaml
sha256: {{ sha256 }}

build:
number: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ask upstream to remove the empty scripts tag and make this noarch as that seems to be the only thing holding it up.

If that's currently not possible you can also just add a patch here removing it.

Ref: https://github.com/googleapis/python-aiplatform/blob/1c341544e9bd94c6ff0ee41177565c8c078673a3/setup.py#L114

Copy link
Contributor Author

@parthea parthea Feb 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this info! I've opened a PR upstream : googleapis/python-aiplatform#1014

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! If you're not sure how soon a new release with that will be cut, you can also include that as a patch here. Let me know if you need any help with that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/google-cloud-aiplatform) and found some lint.

Here's what I've got...

For recipes/google-cloud-aiplatform:

  • Feedstock with the same name exists in conda-forge.

For recipes/google-cloud-aiplatform:

  • A conda package with same name (google-cloud-aiplatform) already exists.

@parthea
Copy link
Contributor Author

parthea commented Mar 15, 2022

Duplicate of #18100

@parthea parthea closed this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@BastianZim BastianZim BastianZim left review comments

@morgandu morgandu morgandu left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parthea @conda-forge-linter @tswast @BastianZim @morgandu