Skip to content

add pandera conda-forge recipe #10114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 12, 2019
Merged

Conversation

cosmicBboy
Copy link
Contributor

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pandera) and found some lint.

Here's what I've got...

For recipes/pandera:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pandera) and found it was in an excellent condition.

@cosmicBboy
Copy link
Contributor Author

@conda-forge/help-python this recipe is ready for review thanks


build:
number: 0
skip: True # [py<35]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a pure Python package, please remove the skip line, and add noarch:python instead.


requirements:
host:
- python
Copy link
Contributor

@npavlovikj npavlovikj Nov 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add python <3.5 in both host and run sections (that is how you can specify the version when noarch is used).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package supports python >= 3.5, would that be python >=3.5 in the host and run sections?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct - it should be python >=3.5 in both sections then.

home: https://github.com/pandera-dev/pandera
license: MIT
license_family: MIT
license_file: LICENSE.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, since you are the developer of the package, it would be nice if you can add the License file in the pypi distribution, so we don't need to add it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the line license_file: LICENSE.txt back. What I meant was that the file LICENSE.txt from the PR can be removed since that file is in the distribution now (sorry for not being clear about that).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha! thanks for clarifying. added it back

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pandera) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pandera:

  • license_file entry is missing, but is expected.

Copy link
Contributor Author

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npavlovikj removed license file (added to 0.2.5 pandera pypi distribution), added noarch: python, and added python version constraint >=3.5 in run and host


requirements:
host:
- python
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package supports python >= 3.5, would that be python >=3.5 in the host and run sections?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pandera) and found it was in an excellent condition.

@xhochy xhochy merged commit 15c1926 into conda-forge:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants