-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
add pandera conda-forge recipe #10114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pandera:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python this recipe is ready for review thanks |
recipes/pandera/meta.yaml
Outdated
|
||
build: | ||
number: 0 | ||
skip: True # [py<35] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a pure Python package, please remove the skip
line, and add noarch:python
instead.
recipes/pandera/meta.yaml
Outdated
|
||
requirements: | ||
host: | ||
- python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add python <3.5
in both host
and run
sections (that is how you can specify the version when noarch
is used).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this package supports python >= 3.5, would that be python >=3.5
in the host and run sections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are correct - it should be python >=3.5
in both sections then.
home: https://github.com/pandera-dev/pandera | ||
license: MIT | ||
license_family: MIT | ||
license_file: LICENSE.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, since you are the developer of the package, it would be nice if you can add the License file in the pypi distribution, so we don't need to add it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the line license_file: LICENSE.txt
back. What I meant was that the file LICENSE.txt
from the PR can be removed since that file is in the distribution now (sorry for not being clear about that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha! thanks for clarifying. added it back
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/pandera:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@npavlovikj removed license file (added to 0.2.5 pandera pypi distribution), added noarch: python
, and added python version constraint >=3.5
in run and host
recipes/pandera/meta.yaml
Outdated
|
||
requirements: | ||
host: | ||
- python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this package supports python >= 3.5, would that be python >=3.5
in the host and run sections?
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)