Drop OpenMP libraries from requirements/host
#241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenMP libraries are already added in `requirements/build`. As both libraries are configured to use `run_exports/strong`, which adds them to `requirements/host` and `requirements/run` automatically, there is no need to add them to `requirements/host`. So this removes them.
jakirkham
requested review from
adrinjalali,
amueller,
astaric,
glemaitre,
jeremiedbb,
jjerphan,
jnothman,
lesteve,
ocefpaf,
ogrisel,
rth and
thomasjpfan
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jjerphan
approved these changes
Dec 6, 2023
…nda-forge-pinning 2023.12.05.22.51.14
|
Thanks Julien! 🙏 Realized I forgot to re-render. Have now done that |
|
Merging, thanks! |
|
Ofc! Thank you both 🙏 |
|
I just have realized that we need to propagate those changes to the |
|
I already did it for the 1.4 rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenMP libraries are already added in
requirements/build. As both libraries are configured to userun_exports/strong(refs:llvm-openmpandlibgomp), which adds them torequirements/hostandrequirements/runautomatically, there is no need to add them torequirements/host. So this removes them.Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)