Skip to content

Migrate to rattler-build and cleanup patches #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 8, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jun 6, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15488995589. Examine the logs at this URL for more detail.

@traversaro
Copy link
Contributor Author

Perfect, the test fail as expected. However, at this point in my experience is difficult to debug issues with conda-build, so even if this is a complex feedstock, it could make sense to first try to migrate to rattler-build.

@traversaro traversaro changed the title Add regression test for not-signed mjpython Add regression test for not-signed mjpython and migrate to rattler-build Jun 7, 2025
@traversaro
Copy link
Contributor Author

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jun 7, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

I had some problem in importing the old patches in rattler-build, so I normalized them by importing them in git on top of the mujoco 3.3.2 tag with git quiltimport, and then I exported them back with git format-patches.

@traversaro
Copy link
Contributor Author

Even after the rattler-build conversion, the segfault is still there:

 │ $SRC_DIR/conda_build.sh: line 14: 22943 Segmentation fault: 11  mjpython --version

@traversaro traversaro changed the title Add regression test for not-signed mjpython and migrate to rattler-build Migrate to rattler-build and cleanup patches Jun 8, 2025
@traversaro
Copy link
Contributor Author

Ok, as the rattler-build migration and patches cleanup is something it make sense to merge indipendently from the mjpython investigation and fixes, I will reopen a follow up PR that uncomments the test to continue to investigation.

@traversaro traversaro merged commit 638af56 into conda-forge:main Jun 8, 2025
9 checks passed
@traversaro traversaro deleted the fix64 branch June 8, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants