Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing package outputs with rattler-build #19

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Oct 8, 2024

rattler_build_conda_compat.render doesn't load the default variants the same way as conda_build.render

this loads and passes the variants dict, instead of just the list of variant files. It is unclear to me if this is truly a bug here, rattler_build_conda_compat, or in staged_recipes.

I believe this fixes conda-forge/staged-recipes#27817 (at least, I was able to run the failing step by hand and it succeeded where it failed before).

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use conda build to combine the variants. I have a code snippet for this in the ci setup package.

@beckermr beckermr enabled auto-merge (squash) October 8, 2024 18:31
@minrk
Copy link
Member Author

minrk commented Oct 8, 2024

Thanks, that's exactly what I was looking for but couldn't find. Copied from here.

@beckermr beckermr merged commit e446053 into conda-forge:main Oct 8, 2024
2 checks passed
@minrk minrk deleted the fix-rattler branch October 8, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error missing stdlib(c) registering new recipe with recipe.yaml
2 participants