6.7.x: Prevent open redirect to other hosts #7460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fell victim to this behaviour: golang/go#38642 The solution in this commit ensures that the URI we redirect to is always a path. The TrimLeft() removes all prefixed forward slashes, which covers the case where a redirect uri starts with two or more slashse. We then always add a single forward slash which will ensure that ParseRequestURI() interprets the URI as a path. Now if someone visits `http://ci.concourse-ci.org/sky/login?redirect_uri=//google.com/` they'll end up redirected to `http://ci.concourse-ci.org/google.com` which will return a 404 and redirect one more time to the homepage. In case the behaviour of ParseRequestURI() changes or is smarter in the future, added check to ensure that if either Host or Scheme is populated that the URI is not used for redirecting. The tests have also been updated so this change in behaviour will cause the tests to fail. Signed-off-by: Taylor Silva <[email protected]> Co-authored-by: Esteban Foronda <[email protected]>
taylorsilva
changed the title
chenbh
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #7459