Skip to content

m4: flag '-FS' available since VS2013(v12) #9515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

snaiffer
Copy link

Specify library name and version: m4/all

conanfile.py for package "m4" has a bug. Flag "-FS" isn't available for VisualStudio under 2013(v12).

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@@ -50,7 +50,8 @@ def _configure_autotools(self):
# The somewhat older configure script of m4 does not understand the canonical names of Visual Studio
build_canonical_name = False
host_canonical_name = False
autotools.flags.append("-FS")
if int(str(self.settings.compiler.version)) >= 12:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if int(str(self.settings.compiler.version)) >= 12:
if tools.Version(self.settings.compiler.version) >= "12":

@ghost
Copy link

ghost commented Feb 25, 2022

I detected other pull requests that are modifying m4/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Apr 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 10, 2022
@ghost ghost mentioned this pull request Apr 13, 2022
@stale stale bot removed the stale label Apr 21, 2022
@conan-center-bot

This comment has been minimized.

2 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

@stale
Copy link

stale bot commented Jun 4, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 4, 2022
@stale
Copy link

stale bot commented Jul 7, 2022

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants