mpdecimal: Enable build on Apple Silicon (M1) #8603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recipe explicitly disabled non-x86 architectures, however `mpdecimal` itself supports pretty much everything. I suspect that non-x86 was originally disabled because of MSVC build complications, as I see that x86 and x64 are explicitly mentioned in the MSVC-specific bits of the recipe. Simply dropping this check on macOS, produces a good build on Apple ARM64 CPUs. Tested on my M1 Mac. I suspect that Linux ARM64 would also work fine but I can't verify this so I've only enabled it for macOS.
|
|
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
madebr
approved these changes
Jan 4, 2022
prince-chrismc
approved these changes
Jan 5, 2022
| @@ -4,6 +4,11 @@ project(test_package) | |||
| include("${CMAKE_BINARY_DIR}/conanbuildinfo.cmake") | |||
| conan_basic_setup(TARGETS) | |||
|
|
|||
| # Workaround for -rpath on arm64: https://cmake.org/cmake/help/latest/release/3.20.html#id2 | |||
| if(CMAKE_VERSION VERSION_LESS "3.20.1" AND CMAKE_OSX_ARCHITECTURES STREQUAL "arm64") | |||
There was a problem hiding this comment.
usually we just require a hire CMake version but this is good to know
miklelappo
pushed a commit
to miklelappo/conan-center-index
that referenced
this pull request
Feb 9, 2022
* mpdecimal: Enable build on Apple Silicon (M1) The recipe explicitly disabled non-x86 architectures, however `mpdecimal` itself supports pretty much everything. I suspect that non-x86 was originally disabled because of MSVC build complications, as I see that x86 and x64 are explicitly mentioned in the MSVC-specific bits of the recipe. Simply dropping this check on macOS, produces a good build on Apple ARM64 CPUs. Tested on my M1 Mac. I suspect that Linux ARM64 would also work fine but I can't verify this so I've only enabled it for macOS. * mpdecimal: Remove fPIC when building shared library * fixup! mpdecimal: Enable build on Apple Silicon (M1) * fixup! mpdecimal: Enable build on Apple Silicon (M1) * fixup! mpdecimal: Enable build on Apple Silicon (M1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: mpdecimal/all
This PR enables building
mpdecimalon Apple ARM. Previously, the recipe explicitly disabled non-x86 architectures, howevermpdecimalitself supports pretty much everything. I suspect that non-x86 was originally disabled because of MSVC build complications, as I see that x86 and x64 are explicitly mentioned in the MSVC-specific bits of the recipe.Simply dropping this check on macOS, produces a good build on Apple ARM64 CPUs. Tested on my M1 Mac.
I suspect that Linux ARM64 would also work fine but I can't verify this so I've only enabled it for macOS.
conan-center hook activated.