libsecret: fix requires in package_info() + modernize #8602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green in build 1 (
|
madebr
approved these changes
Jan 3, 2022
| @@ -105,6 +106,6 @@ def package_info(self): | |||
| self.cpp_info.names["pkg_config"] = "libsecret-1" | |||
| self.cpp_info.requires = ["glib::glib-2.0", "glib::gobject-2.0"] | |||
| if self._use_gcrypt: | |||
| self.cpp_info.requires.append("libgcrypt::gcrypt") | |||
| self.cpp_info.requires.append("libgcrypt::libgcrypt") | |||
There was a problem hiding this comment.
Suggested change
| self.cpp_info.requires.append("libgcrypt::libgcrypt") |
This line was useless in the first place. the if above has to be removed too
There was a problem hiding this comment.
No, it's required due to self.cpp_info.requires = ["glib::glib-2.0", "glib::gobject-2.0"]
ericLemanissier
approved these changes
Jan 3, 2022
miklelappo
pushed a commit
to miklelappo/conan-center-index
that referenced
this pull request
Feb 9, 2022
* fix libgcrypt requires in package_info() * modernize * bump dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
closes #8601
conan-center hook activated.