Skip to content

sentry-native/0.4.12: Bump openssl and libcurl version #7274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2021
Merged

sentry-native/0.4.12: Bump openssl and libcurl version #7274

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fd3df1
sentry-native: Bump openssl and libcurl version
MartinDelille Sep 13, 2021
345584a
Remove crashpad/armv8 support for version < 0.4.7
MartinDelille Sep 20, 2021
acb9d35
Fix equals
MartinDelille Sep 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions recipes/sentry-native/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ def config_options(self):
def configure(self):
if self.options.shared:
del self.options.fPIC

def validate(self):
if self.settings.compiler.cppstd:
tools.check_min_cppstd(self, 14)

Expand All @@ -99,14 +101,16 @@ def configure(self):
raise ConanInvalidConfiguration("The winhttp transport is only supported on Windows")
if tools.Version(self.version) >= "0.4.7" and self.settings.compiler == "apple-clang" and tools.Version(self.settings.compiler.version) < "10.0":
raise ConanInvalidConfiguration("apple-clang < 10.0 not supported")
if self.options.backend == "crashpad" and tools.Version(self.version) < "0.4.7" and self.settings.os == "Macos" and self.settings.arch == "armv8":
raise ConanInvalidConfiguration("This version doesn't support ARM compilation")

def build_requirements(self):
if self.options.backend == "breakpad":
self.build_requires("pkgconf/1.7.4")

def requirements(self):
if self.options.transport == "curl":
self.requires("libcurl/7.75.0")
self.requires("libcurl/7.78.0")
if self.options.backend == "crashpad":
if self.options.with_crashpad == "sentry":
self.requires("sentry-crashpad/{}".format(self.version))
Expand All @@ -119,7 +123,7 @@ def requirements(self):
self.requires("breakpad/cci.20210521")
if self.options.qt:
self.requires("qt/5.15.2")
self.requires("openssl/1.1.1k")
self.requires("openssl/1.1.1l")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious. Does 3.0.0 work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work locally but I didn't test further.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was wondering about the API compatibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility is really freaking close, someone contribute to a project I am apart of https://github.com/Thalhammer/jwt-cpp

One broken const Thalhammer/jwt-cpp@17fdd26

if tools.Version(self.version) < "0.4.5":
raise ConanInvalidConfiguration("Qt integration available from version 0.4.5")

Expand Down