-
Notifications
You must be signed in to change notification settings - Fork 2k
New: Usr: Added gtkmm/2.24.5 #3410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some configurations of 'gtkmm/system' failed in build 1 (
|
Almost all of gtkmm dependencies are already work in progress. I don't think this should be a system package. But we kinda already had that discussion with gtk itself 🤔 💁🏼 |
@Croydon : I reworked it to become gtkmm/2.24.5 rather than gtkmm/system. This, however, leaves me once again with a dependency ( So consider this a work in progress. |
Failure in build 2 (
|
I know that it can be frustrating at times since there is literally endless work for us to do. |
Co-authored-by: Michael Keck <[email protected]>
Some configurations of 'gtkmm/2.24.5' failed in build 3 (
|
self.copy("LICENSE", dst="licenses", src=self._source_subfolder) | ||
autoconf = self._configure_build() | ||
autoconf.install() | ||
tools.rmdir(os.path.join(self.package_folder, "share")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools.rmdir(os.path.join(self.package_folder, "share")) | |
tools.rmdir(os.path.join(self.package_folder, "share")) | |
tools.rmdir(os.path.join(self.package_folder, "res")) |
I see a lot of html files in res/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not. Are we talking about the same package?
|
||
def package_info(self): | ||
self.cpp_info.includedirs = ['include', 'include/gtkmm-2.4', 'include/gdkmm-2.4'] | ||
self.cpp_info.libs = tools.collect_libs(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.cpp_info.libs = tools.collect_libs(self) | |
self.cpp_info.libs = tools.collect_libs(self) | |
self.cpp_info.libdirs.append(os.path.join(self.package_folder, "lib", "cairo")) |
ls /home/conan/.conan/data/cairo/1.17.2/_/_/package/8d0b5f353aa5e0e4f75b6ab896cdd7f05569992f/lib/cairo/
libcairo-trace.a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see that file. Are we talking about the same package (gtkmm
)? Your path seems to suggest otherwise.
Co-authored-by: Uilian Ries <[email protected]>
Some configurations of 'gtkmm/2.24.5' failed in build 4 (
|
if self._autoconf: | ||
return self._autoconf | ||
|
||
self._autoconf = AutoToolsBuildEnvironment(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtkmm has meson support.
Is that working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preferred to use Meson too, but the meson.build
files in the source repository are not in the official release tar balls. Their README talks about separate release tar balls based on autoconf
and meson.build
, but on their own website, I only found the ones supporting autoconf. Ergo, I went with AutoTools for the package.
license = "LGPL-2.1-or-later" | ||
homepage = "https://www.gtk.org" | ||
description = "The C++ API for GTK." | ||
settings = {"os": "Linux"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
settings = {"os": "Linux"} |
options = {"version": [2]} | ||
default_options = {"version": 2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option depends on the value self.options["gtk"].version
, and is thus not choose-able freely.
Having -o gtk:version=2 -o gtkmm:version=3
is an invalid configuration.
Also, I don't see you using this gtk version value anywhere in the recipe.
How does it choose between gtk-2 and gtk-3?
I would do the following:
options = {"version": [2]} | |
default_options = {"version": 2} | |
options = {"version": "auto"} | |
default_options = {"version": "auto"} | |
@property | |
def _gtk_version(self): | |
return self.options["gtk"].version | |
def package_id(self): | |
self.info.options.version = self._gtk_version |
and use self._gtk_version
anywhere.
class GtkmmConan(ConanFile): | ||
name = "gtkmm" | ||
url = "https://github.com/conan-io/conan-center-index" | ||
license = "LGPL-2.1-or-later" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a COPYING.tools
license (GPL-2.0-or-later) for the tools
tools.rmdir(os.path.join(self.package_folder, "share")) | ||
|
||
def package_info(self): | ||
self.cpp_info.includedirs = ['include', 'include/gtkmm-2.4', 'include/gdkmm-2.4'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know how this 2.4
suffix is calculated? It is not equal to gtkmm's version.
|
||
add(m_Table); | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the commented-out code not working? Or can it be removed/re-enabled?
sources: | ||
"2.24.5": | ||
sha256: 0680a53b7bf90b4e4bf444d1d89e6df41c777e0bacc96e9c09fc4dd2f5fe6b72 | ||
url: https://download.gnome.org/sources/gtkmm/2.24/gtkmm-2.24.5.tar.xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually co-operate with the current cci gtk/system
recipe?
We don't have a gtk recipe built from sources (yet).
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Now that #7279 is all green, will we see new developments here? |
@PaulCombal I don't think, but still can fork and open a new Pull request. |
Given sufficient interest, we could. The initial driver for which I created this, is no longer valid |
Specify library name and version: gtkmm/2.24.5
conan-center hook activated.