Skip to content

trantor: use requires explicitly to avoid issues with openssl #27510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lkotsonis
Copy link
Contributor

Summary

Changes to recipe: trantor/[version]

Motivation

In some cases (e.g. cross-compilation), if openSSL is not present, the cmake target is incorrectly communicated as having the alias openssl::openssl. This change makes sure that the correct openSSL names are propagated to the consumers. I had already posted an issue #27497 .

Details

When cross-compiling as a consumer of the library there can be issues with openSSL being correctly detected through its targets. When I tried cross compiling drogon that depends on trantor, I got an error on CMake which basically said that openssl::openssl is not a declared target.

When not cross-compiling that worked fine. That's most likely because my native (x64) configuration had openSSL installed while the cross-compiled host config did not.

The change explicitly sets the names of the dependencies so that the conan-generated openssl::openssl is avoided. This of course means that all the requirements must be explicitly set in package_info().


In some cases (e.g. cross-compilation), if openSSL is not present, the
cmake target is incorrectly communicated as having the alias
openssl::openssl. This change makes sure that the correct openSSL names
are propagated to the consumers.
@lkotsonis
Copy link
Contributor Author

Not sure how much this helps tbh because I figured out that drogon has the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant