Skip to content

Add reduct-cpp #27398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

victor1234
Copy link
Contributor

@victor1234 victor1234 commented May 11, 2025

Summary

Changes to recipe: reduct-cpp/[1.15.0]

Motivation

This PR adds a new recipe for the Reduct C++ SDK, a lightweight HTTP client library for interacting with ReductStore.

Details

A previous attempt to contribute this recipe was made in #23524, but it was not completed and eventually closed.


@CLAassistant
Copy link

CLAassistant commented May 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @victor1234 thanks a lot for taking the time to create this PR.

The current changes do not align with some of the CCI conventions expressed in the package templates at https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package

I've tried to push some changes directly to your branch to clean it up, but I have no permissions to do so from this PR.

Also:

  • A test_package needs to be provided for testing
  • The LICENSE file in this PR can be removed, it's fetched from the sources
  • A patch needs to be added to remove the Conan lookup from the cmake scripts, and added to the conandata.yml

Let me know if you need help with this - I can push the necessary changes if you provide push access to maintainers to this PR

@victor1234 victor1234 marked this pull request as draft May 12, 2025 22:30
@victor1234
Copy link
Contributor Author

@AbrilRBS Thanks, I’ve granted editing access. I’ll add test_package

@victor1234 victor1234 requested a review from AbrilRBS May 13, 2025 22:17
@victor1234 victor1234 marked this pull request as ready for review May 13, 2025 22:18
@victor1234 victor1234 marked this pull request as draft May 16, 2025 14:26
@victor1234 victor1234 marked this pull request as ready for review May 17, 2025 01:39
@victor1234 victor1234 marked this pull request as draft May 17, 2025 01:48
@victor1234 victor1234 marked this pull request as ready for review May 17, 2025 02:06
@victor1234
Copy link
Contributor Author

@AbrilRBS explain your changes, pls

@AbrilRBS
Copy link
Member

@AbrilRBS explain your changes, pls

Sure @victor1234!

Let me know if this helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants