-
Notifications
You must be signed in to change notification settings - Fork 2k
Add reduct-cpp #27398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add reduct-cpp #27398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @victor1234 thanks a lot for taking the time to create this PR.
The current changes do not align with some of the CCI conventions expressed in the package templates at https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package
I've tried to push some changes directly to your branch to clean it up, but I have no permissions to do so from this PR.
Also:
- A test_package needs to be provided for testing
- The LICENSE file in this PR can be removed, it's fetched from the sources
- A patch needs to be added to remove the Conan lookup from the cmake scripts, and added to the conandata.yml
Let me know if you need help with this - I can push the necessary changes if you provide push access to maintainers to this PR
@AbrilRBS Thanks, I’ve granted editing access. I’ll add test_package |
@AbrilRBS explain your changes, pls |
Sure @victor1234!
Let me know if this helps :) |
Summary
Changes to recipe: reduct-cpp/[1.15.0]
Motivation
This PR adds a new recipe for the Reduct C++ SDK, a lightweight HTTP client library for interacting with ReductStore.
Details
A previous attempt to contribute this recipe was made in #23524, but it was not completed and eventually closed.