Skip to content

[ripper37-libbase] Add new recipe (v1.1.1) #27272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RippeR37
Copy link

Summary

This commit adds a new recipe for libbase library. To avoid name clashes and match name with vcpkg I've chosen to use ripper37-libbase recipe name.

Tested locally on Linux and Windows with different modules combinations.

Motivation

Publish new package for easier importing into projects for its users.

Details

I'm the author of libbase project that is a reimplementation of //base module from Chromium. I've recently updated the project and currently aim to make it easier to use for everyone by improving CMake build/installation and publishing it to vcpkg and Conan. The library is modular and allows its users to select which parts of it they want to reduce needed dependencies.


  • Read the contributing guidelines
  • Checked that this PR is not a duplicate: list of PRs by recipe
  • Tested locally with at least one configuration using a recent version of Conan
    • Tested on Windows and Linux platforms with all applicable configurations:
    • &:module_net=[True|False] x &:module_win=[True/False] x &:module_wx=[True/False]

This commit adds a new recipe for `libbase` library. To avoid name
clashes and match name with vcpkg I've chosen to use `ripper37-libbase`
recipe name.

Tested localy on Linux and Windows with different modules combinations.
@CLAassistant
Copy link

CLAassistant commented Apr 22, 2025

CLA assistant check
All committers have signed the CLA.

Backport portability fix to compile on older MSVC2019 on Windows
@RippeR37
Copy link
Author

Updated the PR with a fixup that adds a patch to recipe. The patch is backport of a commit that I applied just after release v1.1.1. It turns out that Conan CI uses older MSVC that isn't/wasn't strictly supported by the library but the issue was in glog headers so changing 2 warnings back to "warning" status was enough to make it work there.

This is already landed in the upstream so in the next version the patch would be removed, but for now I don't want to (re-)release new version just for this small fix so I kept it as a patch here. Tested different module combinations and they work fine (albeit on MSVC2022*).

Please let me know if I can do anything more here or if its ready to be tested and verified :)

@RippeR37 RippeR37 closed this Apr 25, 2025
@RippeR37 RippeR37 reopened this Apr 25, 2025
@RippeR37 RippeR37 closed this Apr 25, 2025
@RippeR37 RippeR37 reopened this Apr 25, 2025
@RippeR37
Copy link
Author

Hey, any way to unblock this? It was +/- green before, but I saw a linter error/warning so I update the PR to ensure that it won't block it later on but it seems to be stuck on pre-CI jobs (not approved to run them again?). Would be nice to land this finally, let me know what I can do to help out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants