ohnet: Update to 1.38 #27210
ohnet: Update to 1.38 #27210
Conversation
recipes/ohpipeline/all/conanfile.py
Outdated
| @@ -48,7 +48,7 @@ def build_requirements(self): | |||
| self.tool_requires("cmake/[>3.23 <4]") | |||
|
|
|||
| def requirements(self): | |||
| self.requires("ohnet/1.37.5454", transitive_headers=True, transitive_libs=True) | |||
There was a problem hiding this comment.
Please limit the PR to one recipe, thanks!
DoomHammer
force-pushed
the
ohnet-1.38.5707
branch
from
2e9ab77 to
8d72c89
Compare
There was a problem hiding this comment.
Here is the diff between versions
openhome/ohNet@ohNet_1.37.5454...ohNet_1.38.5707
| - $(compiler)anonymous.$(objext) -c $(cflags_third_party) $(includes) $(mDNSdir)/anonymous.c | ||
| + $(compiler_cc)anonymous.$(objext) -c $(cflags_third_party) $(includes) $(mDNSdir)/anonymous.c | ||
| $(objdir)CryptoAlg.$(objext) : $(mDNSdir)/CryptoAlg.c $(headers) | ||
| - $(compiler)CryptoAlg.$(objext) -c $(cflags_third_party) $(includes) $(mDNSdir)/CryptoAlg.c | ||
| + $(compiler_cc)CryptoAlg.$(objext) -c $(cflags_third_party) $(includes) $(mDNSdir)/CryptoAlg.c | ||
| $(objdir)DNSCommon.$(objext) : $(mDNSdir)/DNSCommon.c $(headers) | ||
| - $(compiler)DNSCommon.$(objext) -c $(cflags_third_party) $(includes) $(mDNSdir)/DNSCommon.c | ||
| + $(compiler_cc)DNSCommon.$(objext) -c $(cflags_third_party) $(includes) $(mDNSdir)/DNSCommon.c |
There was a problem hiding this comment.
I find a lot of changes between this patch and the 1.37 patch.
Could you help me track all these changes to upstream issues?
There was a problem hiding this comment.
Upstream does not respond to any issues so it is useless to file them there, unfortunately.
There was a problem hiding this comment.
The changes introduced by the patch should be backed by merged upstream PRs that address specific issues or be strictly necessary modifications to ensure compatibility with Conan, in which case, it would also be helpful to provide a clear justification.
There was a problem hiding this comment.
This is strictly necessary to build this piece of software at all. And upstream is not responding. We've been through this before with previous versions.
| @@ -79,7 +79,7 @@ def _fill_ohnet_args(self, args): | |||
| args = self._fill_openhome_architecture(args) | |||
| args.append("rsync=no") | |||
| if str(self.settings.compiler.libcxx) == "libc++": | |||
| args.extend(["CPPFLAGS=-stdlib=libc++", "LDFLAGS=-stdlib=libc++"]) | |||
| args.extend(["CPPFLAGS=-stdlib=libc++", "LDFLAGS=-stdlib=libc++", "PYTHON=python3"]) | |||
There was a problem hiding this comment.
Why does this flag now need it?
There was a problem hiding this comment.
The original make script calls python which on many systems mean python2 as contrasted to python3. As you might imagine, I'm not a fan of installing Python 2 on people's machines.
Summary
Changes to recipe: ohnet/1.38
Motivation
Details