-
Notifications
You must be signed in to change notification settings - Fork 2k
gsoap: add v2.8.138 #27173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
gsoap: add v2.8.138 #27173
Conversation
This reverts commit 2a0c9d4.
"2.8.138": | ||
url: | ||
- "https://sourceforge.net/projects/gsoap2/files/gsoap_2.8.138.zip/download" | ||
- "https://c3i.jfrog.io/artifactory/conan-center-backup-sources/5ddd63eebd6a08e1838e93400a843975c65ae77e09a95276f9adf166d3ca6f74" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this as a mirror - it's not an official mirror, and the documented way to use it is transparently without modifying the recipes, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jcar87, thank you for the review. I just followed the instruction at the top of the conandata file:
# The sources for this project get deleted from time to time. # We use the backup sources from Conan Center as mirrors to let users compile in the future # When adding new versions, directly add the URL following previous versions schema # https://c3i.jfrog.io/artifactory/conan-center-backup-sources/ + sha256 of the sources # The file will be automatically uploaded after the first successful compilation of the new version # And will be usable as a mirror from then on. # At some point the Conan client might come pre-configured with this backup remote by default, but don't delete the links then # some users might still rely on the old revisions/not have it set to point to our CCI backup remote
I do not know enough about conan to decide if it's a good idea to do that or not. However I think it should be consistent within the file. Meaning if we remove the conan-center-backup-sources
url from one version, it should be removed from all versions. For now I prefer following the instructions and let somebody else (in annother PR) decide if all those conan-center-backup-source
url's should be removed or not.
According to
#At some point the Conan client might come pre-configured with this backup remote by default, but don't delete the links then # some users might still rely on the old revisions/not have it set to point to our CCI backup remote`
it would make sense to keep the old conan-center-backup-source
links but not add new ones if the conan client comes pre-configured with this backup remote nowadays. Is this the case?
Summary
Changes to recipe: gsoap/2.8.138
Motivation
New upstream version
Details