-
Notifications
You must be signed in to change notification settings - Fork 2k
[libmount] Add option to disable year2038 support. #27161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Cherry-picked from conan-io#27161 by @wdobbe
@wdobbe Thank you for your suggestion! Could you please provide a more detailed case about your scenario? I see no related issue where I could reproduce your case. Could you please share a full build log where libmount is failing to build? Regards! |
@uilianries Sorry for the late reply, I was on holiday. Below is the log of the failed build when I don't provide the
|
@wdobbe Thank you for providing more details—your scenario is much clearer now. I see your case as very specific for cross-building and very reserved for your build. In Conan Center Index, we try to avoid adding new recipe options unless they reflect a well-used variant or add an extra dependency when building. This is because the CI does not validate extra options, and it is not only a further review, including local build, but also affects the package ID, resulting in a cascade effect over other packages that are consuming the specific package. Talking about the
Plus, I did not find a quorum in ConanCenterIndex, based on opened issues, asking for the same option. Based on that, I'm not inclined to accept this change, but this does not mean you will be blocked. Here are some options that you can adopt to fix your situation:
I hope these suggestions help. Please feel free to share your thoughts or ask further questions. |
Summary
Changes to recipe: libmount/2.40.2
Motivation
In order to cross-compile libmount with an (old) ArmV5 toolchain I needed to configure libmount with the
--disable-year2038
option.Details
On legacy platforms sometimes the only way to get libmount compiled is to disable year2038 support.